Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B020: Fix comprehension false postives #238

Merged
merged 1 commit into from Mar 22, 2022
Merged

B020: Fix comprehension false postives #238

merged 1 commit into from Mar 22, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 22, 2022

Closes #235.

Fixes a false positive for B020 where a variable defined in a comprehension is reused in the for loop targets.

cooperlees
cooperlees approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks. So clean and Pythonic Objecty. Much love.

@cooperlees cooperlees merged commit a4dc2b7 into PyCQA:main Mar 22, 2022
@cooperlees
Copy link
Collaborator

Will give it another 24 hours for reports then release this. Cause you watch us get something as soon as I release this fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG/QUESTION: Not sure if B020 is expected to trigger here
2 participants
@jpy-git @cooperlees