Allow the same special cases for B950 as E501 (#176) #213
Conversation
percurnicus
force-pushed
the
use_E501_special_cases
branch
2 times, most recently
from
81c2020
to
bf5f79e
Compare
percurnicus
changed the title
percurnicus
force-pushed
the
use_E501_special_cases
branch
from
bf5f79e
to
d77e974
Compare
bugbear.py
Outdated
| @@ -12,7 +12,7 @@ | |||
| import attr | |||
| import pycodestyle | |||
|
|
|||
| __version__ = "21.11.29" | |||
| __version__ = "21.12.0" | |||
There was a problem hiding this comment.
Lets not do this here and I'll do it on a diff when I release (as it's going to be 22.*)
|
|
||
| is_line_comment_url_path = len(chunks) == 2 and chunks[0] == "#" | ||
|
|
||
| just_long_url_path = len(chunks) == 1 |
There was a problem hiding this comment.
So if I read this right, really this is just a long no white space string right? So it could not be a URL or file path? I guess generally we'll have spaces I guess is the rationale here right?
Is this the same as how pycodestyle does it? if so, (Sorry - being lazy and not checking), then I guess it's proven to be safe enough.
There was a problem hiding this comment.
Yeah, a long string with no white space, which is mostly just URLs and paths. A path that has a space in it will still fail but would also fail E501. Rational is it is more readable to not split up URLs and paths in comments and code.
It's the same logic as pycodestyle, modified to be a bit more readable to me. Linking here for convenience.
Fixes #176
Allows for the same special cases as E501 for B950