Do not crash on call in except statement #187

jaap3 · 2021-09-28T20:04:22Z

This fixes the crash reported in issue #171. Not sure if this is the correct way to fix this, but at least it doesn't crash.

cooperlees

Looks right to me. If CI passes I'll merge and look at getting a version out.

Many thanks for the Test driven fix! Welcome to flake8-bugbear family of contributors.

cooperlees

Bah - Sorry to be a pain, but our good friend black is uphappy with the formatting. Can you just fix that.

jaap3 · 2021-09-28T21:24:09Z

Super weird, I already ran black on it. Just ran it again and I get no changes:

$ black .
All done! ✨ 🍰 ✨
25 files left unchanged.

$ black --version
black, version 21.9b0

cooperlees · 2021-09-28T21:26:58Z

Super weird, I already ran black on it. Just ran it again and I get no changes:
$ black .
All done! ✨ 🍰 ✨
25 files left unchanged.
$ black --version
black, version 21.9b0

We're running and testing out the "experimental-string-processing" feature.

So you'll need: black --experimental-string-processing .

jaap3 · 2021-09-28T21:28:22Z

Ah, just noticed that as well. Should be good now.

Edit: Oof, I don't like what black did there :(. Why isn't the test right above it reformatted? I basically copied the multiline string from there.

cooperlees · 2021-09-28T21:31:26Z

tests/test_bugbear.py

+        # akin to test_does_not_crash_on_tuple_expansion_in_except_statement
+        # see https://github.com/PyCQA/flake8-bugbear/issues/171
+        syntax_tree = ast.parse(
+            "foo = lambda: IOError\ntry:\n    ...\nexcept (foo(),):\n    ...\n"


I too, don't like this autoformat ...

cc: @ichard26 @JelleZijlstra @zsol - I think this will get complaints ... thoughts?

Aren't user splits preserved unless they violate the length limit according to the ESP rules? Or does a function call mess that up?

Maybe the issue is that the string put together isn't long enough to hit the line length limit, so we put it all together.

I think this is similar to psf/black#1540

jaap3 force-pushed the patch-1 branch from f1c654c to 189b993 Compare September 28, 2021 20:20

jaap3 marked this pull request as ready for review September 28, 2021 20:21

cooperlees approved these changes Sep 28, 2021

View reviewed changes

cooperlees requested changes Sep 28, 2021

View reviewed changes

Do not crash on call in except statement

4f4534f

jaap3 force-pushed the patch-1 branch from 189b993 to 4f4534f Compare September 28, 2021 21:27

cooperlees reviewed Sep 28, 2021

View reviewed changes

cooperlees approved these changes Sep 28, 2021

View reviewed changes

cooperlees merged commit fdfa3a0 into PyCQA:master Sep 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not crash on call in except statement #187

Do not crash on call in except statement #187

jaap3 commented Sep 28, 2021 •

edited

cooperlees left a comment

cooperlees left a comment

jaap3 commented Sep 28, 2021 •

edited

cooperlees commented Sep 28, 2021

jaap3 commented Sep 28, 2021 •

edited

cooperlees Sep 28, 2021

ichard26 Sep 28, 2021 •

edited

JelleZijlstra Sep 28, 2021

jaap3 Sep 29, 2021

Do not crash on call in except statement #187

Do not crash on call in except statement #187

Conversation

jaap3 commented Sep 28, 2021 • edited

cooperlees left a comment

Choose a reason for hiding this comment

cooperlees left a comment

Choose a reason for hiding this comment

jaap3 commented Sep 28, 2021 • edited

cooperlees commented Sep 28, 2021

jaap3 commented Sep 28, 2021 • edited

cooperlees Sep 28, 2021

Choose a reason for hiding this comment

ichard26 Sep 28, 2021 • edited

Choose a reason for hiding this comment

JelleZijlstra Sep 28, 2021

Choose a reason for hiding this comment

jaap3 Sep 29, 2021

Choose a reason for hiding this comment

jaap3 commented Sep 28, 2021 •

edited

jaap3 commented Sep 28, 2021 •

edited

jaap3 commented Sep 28, 2021 •

edited

ichard26 Sep 28, 2021 •

edited