Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B008: Whitelist additional immutable function calls #173

Merged
merged 1 commit into from Aug 11, 2021
Merged

B008: Whitelist additional immutable function calls #173

merged 1 commit into from Aug 11, 2021

Conversation

ThiefMaster
Copy link
Contributor

closes #172

I did not whitelist unqualified compile since pretty much everyone uses re.compile and compile is also a built-it with a completely different meaning.

cooperlees
cooperlees approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree with the compile choice. This makes less noise, so I support it.

Will leave it for a few days to see if anyone else comments before I merge.

@cooperlees cooperlees merged commit 117aeaf into PyCQA:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

B008: Whitelist operator.{attrgetter,itemgetter,methodcaller} default args
2 participants
@ThiefMaster @cooperlees