Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B015 Pointless comparison advice is not complete #149

Closed
stevepiercy opened this issue Nov 29, 2020 · 2 comments
Closed

B015 Pointless comparison advice is not complete #149

stevepiercy opened this issue Nov 29, 2020 · 2 comments

Comments

@stevepiercy
Copy link
Contributor

I like this new feature, yet the warning message tells me to do something that I should not do. Also its grammar has a mistake.

B015 Pointless comparison. This comparison does nothing but wastes CPU instructions. Remove it.

I think it should be:

B015 Pointless comparison. This comparison does nothing but waste CPU instructions. Either prepend "assert" or remove it.

To verify grammar, remove "nothing but" from "This comparison does nothing but waste" to get the proper verb tense, i.e., "This comparison does waste". Englishing is hard.

See #130
stevepiercy added a commit to stevepiercy/flake8-bugbear that referenced this issue Nov 29, 2020
@stevepiercy
B015: prepend "assert" and fix verb tense
1bc3558 
- See PyCQA#149
@stevepiercy stevepiercy mentioned this issue Nov 29, 2020
Merged
cooperlees pushed a commit that referenced this issue Nov 29, 2020
@stevepiercy
B015: prepend "assert" and fix verb tense (#150)
836139b 
- See #149
@cooperlees
Copy link
Collaborator

Merged the provided PR. Thanks!

@stevepiercy
Copy link
Contributor Author

Closed by #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevepiercy @cooperlees