Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude types.MappingProxyType() from B008 #144

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Exclude types.MappingProxyType() from B008 #144

merged 2 commits into from
Nov 13, 2020

Conversation

hukkin
Copy link

@hukkin hukkin commented Nov 13, 2020

Exclude the read-only types.MappingProxyType() from B008 similar to tuple() and frozenset().

cooperlees
cooperlees approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This makes sense to me since we're >= 3.6. I'll make sure CI passes and then merge. We're due for a release this month. I'll try spend some time this weekend.

@cooperlees
Copy link
Collaborator

If you want to help speed me up - Please add the change to README.rst please.

@hukkin
Copy link
Author

hukkin commented Nov 13, 2020

👍 Updated the README

@cooperlees cooperlees merged commit 7b73c9d into PyCQA:master Nov 13, 2020
@hukkin hukkin deleted the mappingproxytype-b008-ignore branch November 13, 2020 19:29
This was referenced Mar 9, 2021
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 16, 2021
Merged
Merged
@hukkin hukkin mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperlees cooperlees cooperlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hukkin @cooperlees @hukkinj1