Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for raising a literal #141

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Oct 17, 2020

This is invalid and the user likely intended to return instead.
GitHub code search is not great but shows a few instances of this:

https://github.com/search?l=Python&p=1&q=%22raise+False%22&type=Code

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

If you see this before I merge - Can you add the change to “Change Log” in README.rst

This is invalid and the user likely intended to return instead.
GitHub code search is not great but shows a few instances of this:

https://github.com/search?l=Python&p=1&q=%22raise+False%22&type=Code
@gaul
Copy link
Contributor Author

gaul commented Oct 19, 2020

If you see this before I merge - Can you add the change to “Change Log” in README.rst

Done.

@cooperlees
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants