Silence B009/B010 for non-identifiers #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an object implements __getattr__ and/or __setattr__, the second parameter to getattr() or setattr() may not be a valid Python identifier (e.g. getattr(foo, "123abc"). In this case bugbear should not emit B009/B010, since changing to "foo.123abc" would be a SyntaxError. Update the B009/B010 detection to check using a regex.
cooperlees
approved these changes
Jan 26, 2020
|
Thanks! |
|
Thanks for contributing! Appreciate eliminating all false positives! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an object implements
__getattr__and/or__setattr__, the second parameter to agetattr()orsetattr()call might not be a valid Python identifier (e.g.getattr(foo, "123abc")). In this case bugbear should not emit B009/B010, since changing tofoo.123abcwould be a SyntaxError. Update the B009/B010 detection to check using a regex.Fixes #113.