Build of artifact fails if raw directive used #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to center the logo made use of the html raw keyword in the README. Apparently this fails when building the Bandit artifact. Checking dist/bandit-1.7.3.dev33-py3-none-any.whl: FAILED `long_description` has syntax errors in markup and would not be rendered on PyPI. line 1: Warning: "raw" directive disabled. warning: `long_description_content_type` missing. defaulting to `text/x-rst`. This change reverts the centering, but keeps the updated link. Signed-off-by: Eric Brown <browne@vmware.com>
ericwb
requested review from
lukehinds,
ghugo and
sigmavirus24
as code owners
This was referenced Feb 28, 2022
Merged
| <img src="https://raw.githubusercontent.com/pycqa/bandit/main/logo/logotype-sm.png" alt="Bandit"> | ||
| </p> | ||
| .. image:: https://raw.githubusercontent.com/pycqa/bandit/main/logo/logotype-sm.png | ||
| :alt: Bandit |
There was a problem hiding this comment.
https://docutils.sourceforge.io/docs/ref/rst/directives.html#image Allows for :align: e.g.,
.. image:: https://raw.githubusercontent.com/pycqa/bandit/main/logo/logotype-sm.png
:alt: Bandit logo
:align: centerThere was a problem hiding this comment.
Yeah, I initially tried using align but it seems GitHub doesn't support that tag.
This was referenced Feb 28, 2022
Merged
chore(deps): update pre-commit hook pycqa/bandit to v1.7.3
browniebroke/flake8-django-migrations#174
Merged
This was referenced Feb 28, 2022
Merged
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to center the logo made use of the html raw keyword
in the README. Apparently this fails when building the Bandit artifact.
This change reverts the centering, but keeps the updated link.
Signed-off-by: Eric Brown browne@vmware.com