Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pyproject.toml as config file format #550

Closed
a-recknagel opened this issue Nov 17, 2019 · 11 comments · Fixed by #401
Closed

Support for pyproject.toml as config file format #550

a-recknagel opened this issue Nov 17, 2019 · 11 comments · Fixed by #401
Labels
enhancement New feature or request

Comments

@a-recknagel
Copy link

a-recknagel commented Nov 17, 2019

PEP 518 specifies a config format that can be exploited by dev tools through designated sections, given their pyPI domain. The toml format is very basic and should allow a simple 1 to 1 mapping of the existing config, since it is more on the minimal side. Given the following .bandit file:

[bandit]
targets: src
skips: B101,B110

Its section in a pyproject.toml would look like this:

[tool.bandit]
targets = ["src"]
skips = ["B101", "B110"]

The sole gain of supporting this would be to reduce the amount of additional config files needed for using bandit in a python project that uses PEP 518 in some way from 1 to 0.


Discussions on other tools regarding the same issue:

@ericwb
Copy link
Member

ericwb commented Nov 20, 2019

Note, there is a PR in progress: #401

@ericwb ericwb added the enhancement New feature or request label Nov 20, 2019
@a-recknagel
Copy link
Author

Thanks for pointing it out, I only searched the issues. Since it just extends the yaml config (that I wasn't even aware of), it should handle the example I proposed and much more, so it would close this issue satisfactorily.

@moon-bits
Copy link

@ericwb I'm sorry to say that: But this is getting ridiculous.

There is a pending PR #401 since October 2018, and you waste the time of the poor guy that still maintains the branch to keep it free from merge conflicts.

Just merge it and please don't block it unnecessarily. We wait since 2 years for that feature that has been already implemented.

@derek-miller
Copy link

Any update here? Can you either merge the PR or reject it? Nearly all other linting related packages have support for pyproject.toml at this point and a shame users still need to use multiple configuration files for a solved problem.

@grizz
Copy link

grizz commented Jul 17, 2021

Seriously... please? :)

@kasium
Copy link

kasium commented Aug 11, 2021

Guys, this feature is really requested. We have already a finished PR by @orsinium. Can you please finally decide on this?
@ericwb can you please have a look?

@kasium
Copy link

kasium commented Aug 31, 2021

Thanks a lot! Can you please publish a new release so that users can actually use it?

@WayneLambert
Copy link

Like others, I agree that it would be really great if a new release was on PyPI so that the Python community can benefit from the work that @orsinium and the other contributors/maintainers have done.

@PabloLec
Copy link

PabloLec commented Oct 4, 2021

Same here, given the age of the last release and the number of updates pending I think a new version should already be out.

@orsinium
Copy link
Contributor

orsinium commented Oct 5, 2021

I did the PR 4 Hacktoberfest's ago, since then I have changed 3 cities, 2 countries, and 4 jobs, built a house, created 50+ small projects. So, be patient and just don't make expectations about the release date 😉

@PabloLec
Copy link

PabloLec commented Oct 5, 2021

Ok, I guess I'll focus on building a house too and come back later 😉

jtbandes added a commit to foxglove/rosbridge_suite that referenced this issue Nov 5, 2021
…gs.json

Bandit will soon support configuration via pyproject.toml but a version supporting this has not yet been released. See PyCQA/bandit#550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants