Remove pycryptodome blacklist #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pycryptodome appears to be actively maintained, as opposed to pycrypto. Unless there is a noted security issue with not using it, this removes the blanket blacklist on the library. Any insecure hashes/ciphers/etc. that the library provides will still be reported as per other libraries.
- repurpose blacklist test to verify that pycryptodome is no longer blacklisted
mikespallino
force-pushed
the
remove-pycryptodome
branch
from
06314e0
to
0919a3b
Compare
|
Thanks for picking this back up @mikespallino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @ghugo for the actual fix. Opening a new PR since they haven't updated #417 fixing the build.