Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting CSafeLoader in yaml.load plugin #436

Merged
merged 3 commits into from Dec 15, 2018

Conversation

domanchi
Copy link
Contributor

PyYAML also supports CSafeLoader. This is used for faster loading, if you have the right libraries installed. This check should not alert off this loader, because it is still safe (just faster).

While I was at it, I also did a bit of minor refactoring, to reduce the number of indents used.

@ehooo
Copy link
Contributor

ehooo commented Dec 14, 2018

@domanchi could you create an issue related to this PR? Could you also add a test?
Thanks in advance.

@domanchi
Copy link
Contributor Author

Fixes #437.

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ericwb ericwb merged commit c55e46c into PyCQA:master Dec 15, 2018
@domanchi domanchi deleted the yaml-plugin-include-csafeloader branch December 17, 2018 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants