Properly handle nosec strings in code #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string "# nosec" has a chance (albeit remote) that it can be part of the code on the line not just within the comment. Bandit currently checks the entire line for that string. This patch tokenizes the line of input to figure out what piece is a comment, then compares whether that comment contains "# nosec". Fixes #383 Signed-off-by: Eric Brown <browne@vmware.com>
|
LGTM, happy to merge once CI passes, unless @sigmavirus24 or @ghugo have concerns? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string "# nosec" has a chance (albeit remote) that it can be
part of the code on the line not just within the comment. Bandit
currently checks the entire line for that string.
This patch tokenizes the line of input to figure out what piece
is a comment, then compares whether that comment contains "# nosec".
Fixes #383
Signed-off-by: Eric Brown browne@vmware.com