Fix custom format argument handling #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2018 15:43
Signed-off-by: Antoine Salon <asalon@vmware.com>
Signed-off-by: Antoine Salon <asalon@vmware.com>
ericwb
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
So, looks like we have a bigger issue where not all of the formatters honor the number of output lines of code to include in the report. This fixes custom since it was using "lines" incorrectly, but we probably need a separate PR to fix all formatters to honor the lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for limiting the number of reports since it is not used anyway.
Closes #371