Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for httpx in B113 (request_without_timeout) #1059

Open
mkniewallner opened this issue Sep 19, 2023 · 0 comments · May be fixed by #1060
Open

Add support for httpx in B113 (request_without_timeout) #1059

mkniewallner opened this issue Sep 19, 2023 · 0 comments · May be fixed by #1060
Labels
enhancement New feature or request

Comments

@mkniewallner
Copy link
Contributor

mkniewallner commented Sep 19, 2023

Is your feature request related to a problem? Please describe.
httpx has APIs that are really similar to requests. Currently, in B113 (request_without_timeout), bandit only checks that timeouts are set in requests, but not in httpx.

Describe the solution you'd like
Additionally to checking requests in B113, bandit could also check for requests without timeout in httpx.

Describe alternatives you've considered
Implementing a new rule, but since support for httpx has been added in #861, it would probably be more consistent to update the existing B113 rather than implementing a new rule.

Additional context
Implementation is in #1060, if you think that this would be useful to add.

Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.

@mkniewallner mkniewallner added the enhancement New feature or request label Sep 19, 2023
@mkniewallner mkniewallner linked a pull request Sep 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant