Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inference_tip for typing.TypedDict brain #928

Merged
merged 1 commit into from Apr 7, 2021
Merged

Use inference_tip for typing.TypedDict brain #928

merged 1 commit into from Apr 7, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Apr 1, 2021

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

The typing brain should use inference_tip for TypedDict instead of a normal transform.
The pylint tests continue to pass with this change.

Type of Changes

Type
✓ 🔨 Refactoring

@cdce8p cdce8p requested a review from hippo91 April 4, 2021 11:05
@cdce8p
Copy link
Member Author

cdce8p commented Apr 4, 2021

@hippo91 Would you mind taking a quick look at this one? After you used inference_tip, I realized that it's probably a better fit here too.

@hippo91 hippo91 self-assigned this Apr 5, 2021
hippo91
hippo91 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@hippo91 hippo91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdce8p it seems to be a better implementation. Well done.

astroid/brain/brain_typing.py Show resolved Hide resolved
@cdce8p cdce8p merged commit 76172d4 into pylint-dev:master Apr 7, 2021
@cdce8p cdce8p deleted the fix-typedDict branch April 7, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hippo91 hippo91 hippo91 approved these changes

Assignees

@hippo91 hippo91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdce8p @hippo91