Bug pylint 3974 #918
Merged
Bug pylint 3974 #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en numpy is imported without alias whereas it is ok when numpy is imported with an alias. It should be investigated but is probably beyond the scope of this work.
|
@cdce8p for an unknown reason, i cannot add you as a reviewer but i would be happy to have your opinion on this PR. |
Pierre-Sassoulas
approved these changes
Mar 5, 2021
cdce8p
reviewed
Mar 5, 2021
There was a problem hiding this comment.
The change looks reasonable. Although I know too little about astroid, to evaluate it without debugging 😅
I'm not a member of PyCQA and don't have any permissions for either repo (astroid and pylint). That's probably why you couldn't request a review from me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This PR fixes the way an Import node is detected as a valid
numpyimport. It concerns only thenumpy's brain.The
_is_a_numpy_modulefunction was bugged because it returns True forimport numpy as aliasbut False for the simplest caseimport numpy.Type of Changes
Related Issue
Closes pylint-dev/pylint#3974