Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent returning an empty list for ClassDef.slots() #1861

Merged
merged 3 commits into from Nov 3, 2022
Merged

Prevent returning an empty list for ClassDef.slots() #1861

merged 3 commits into from Nov 3, 2022

Conversation

mbyrnepr2
Copy link
Member

Prevent returning an empty list for ClassDef.slots() when the mro list contains one class & it is not object.

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

Refs pylint-dev/pylint#5099

@mbyrnepr2 mbyrnepr2 added this to the 2.13.0 milestone Nov 2, 2022
@coveralls
Copy link

coveralls commented Nov 2, 2022 •
edited

Pull Request Test Coverage Report for Build 3385374004

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.273%
Totals Coverage Status
Change from base Build 3367353146: 0.001%
Covered Lines: 9864
Relevant Lines: 10690
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mbyrnepr2 mbyrnepr2 marked this pull request as ready for review November 3, 2022 07:23
cdce8p
cdce8p requested changes Nov 3, 2022
View reviewed changes
astroid/nodes/scoped_nodes/scoped_nodes.py Outdated Show resolved Hide resolved
@mbyrnepr2 @cdce8p
Use Marc's suggestion from code review.
f48e7ac 
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@cdce8p cdce8p modified the milestones: 2.13.0, 2.12.13 Nov 3, 2022
cdce8p
cdce8p approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mbyrnepr2 👍🏻
I've tagged this for 2.12.13.

@cdce8p cdce8p merged commit 2d34699 into pylint-dev:main Nov 3, 2022
@mbyrnepr2 mbyrnepr2 deleted the pylint_issue_5099 branch November 3, 2022 20:39
@cdce8p cdce8p mentioned this pull request Nov 4, 2022
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
@mbyrnepr2 @cdce8p @Pierre-Sassoulas
Prevent returning an empty list for ClassDef.slots() (#1861)
181aed8 
Prevent returning an empty list for `ClassDef.slots()` when the mro list contains one class & it is not `object`. Refs pylint-dev/pylint#5099

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Pierre-Sassoulas pushed a commit that referenced this pull request Nov 19, 2022
@mbyrnepr2 @cdce8p @Pierre-Sassoulas
Prevent returning an empty list for ClassDef.slots() (#1861)
a48a915 
Prevent returning an empty list for `ClassDef.slots()` when the mro list contains one class & it is not `object`. Refs pylint-dev/pylint#5099

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Nov 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Bug 🪳
Projects
None yet
Milestone
2.12.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mbyrnepr2 @coveralls @Pierre-Sassoulas @cdce8p