Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI deployment environment [ci] #1855

Merged
merged 1 commit into from Oct 26, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 26, 2022

Description

Add an environment for the release workflow. This will allow for additional protection rules and better secrets scoping.
https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

Note
It would make sense to move the PYPI_API_TOKEN secret. That way other workflows won't be able to access it.

--

I've also added a wildcard tag protection rule. Thus only users with the admin or maintain permission will be able to create new tags.
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/configuring-tag-protection-rules

@cdce8p cdce8p added Needs backport Maintenance Discussion or action around maintaining astroid or the dev workflow labels Oct 26, 2022
@cdce8p cdce8p added this to the 2.12.13 milestone Oct 26, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3327840878

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.272%

Totals Coverage Status
Change from base Build 3323538272: 0.0%
Covered Lines: 9862
Relevant Lines: 10688

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These permission changes are most welcome!

@cdce8p cdce8p merged commit efebf43 into pylint-dev:main Oct 26, 2022
@cdce8p cdce8p deleted the ci-environment branch October 26, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants