Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the __init__ of dataclassess with multiple inheritance #1774

Merged
merged 1 commit into from Sep 7, 2022
Merged

Fixed the __init__ of dataclassess with multiple inheritance #1774

merged 1 commit into from Sep 7, 2022

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Sep 7, 2022 •
edited

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes pylint-dev/pylint#7427

Refs. #1768 #1764 #1770

This list is getting long...

Type of Changes

Type
✓ 🐛 Bug fix

@Pierre-Sassoulas Our tests for dataclasses are getting so robust now 🎉 😅

@DanielNoord DanielNoord added this to the 2.12.9 milestone Sep 7, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3006107591

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 92.419%
Totals Coverage Status
Change from base Build 3005854917: 0.006%
Covered Lines: 9777
Relevant Lines: 10579
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's shiiiiip it 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit b5812cc into pylint-dev:main Sep 7, 2022
Pierre-Sassoulas pushed a commit that referenced this pull request Sep 7, 2022
@DanielNoord @Pierre-Sassoulas
Fixed the __init__ of dataclassess with multiple inheritance (#…
e41155d 
…1774)
@DanielNoord DanielNoord deleted the dataclasses-KW-ONLY branch September 7, 2022 10:36
Pierre-Sassoulas pushed a commit that referenced this pull request Sep 7, 2022
@DanielNoord @Pierre-Sassoulas
Fixed the __init__ of dataclassess with multiple inheritance (#…
449a95b 
…1774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Regression
Projects
None yet
Milestone
2.12.9
Development

Successfully merging this pull request may close these issues.

False positive with dataclass multiple inheritance and field init
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas