Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash on namedtuples that use typename #1773

Merged
merged 4 commits into from Sep 7, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Closes pylint-dev/pylint#7429

Type of Changes

Type
🐛 Bug fix

@Pierre-Sassoulas I couldn't get the inference failure path to cover, I think it is covered in another path.

Anyway I think it is good to have there, even if uncovered.

@coveralls
Copy link

coveralls commented Sep 7, 2022

Pull Request Test Coverage Report for Build 3005851896

  • 9 of 11 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 92.412%

Changes Missing Coverage Covered Lines Changed/Added Lines %
astroid/brain/brain_namedtuple_enum.py 9 11 81.82%
Totals Coverage Status
Change from base Build 3001787275: -0.002%
Covered Lines: 9768
Relevant Lines: 10570

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ChangeLog Show resolved Hide resolved
ChangeLog Show resolved Hide resolved
ChangeLog Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas merged commit 7c36d11 into pylint-dev:main Sep 7, 2022
@DanielNoord DanielNoord deleted the namedtuple-crash branch September 7, 2022 08:21
Pierre-Sassoulas added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash AttributeError: 'ClassDef' object has no attribute 'value'
3 participants