Add typing in tests directory #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
Maintenance
4 tasks
Pierre-Sassoulas
force-pushed
the
add-typing-in-tests
branch
from
d3c841d
to
f841367
Compare
Pierre-Sassoulas
force-pushed
the
add-typing-in-tests
branch
2 times, most recently
from
4299098
to
8365006
Compare
Pierre-Sassoulas
force-pushed
the
add-typing-in-tests
branch
from
8365006
to
a91360b
Compare
cdce8p
reviewed
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding typing in tests, we're not ready for using mypy yet. The design of
extract_nodesthat return a Node or a list of Node is peculiar and will probably cause a lot of typing issues.Type of Changes