Fixes #377, renders the html that can be manipulated with writer #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygedeon
changed the title
mna
requested changes
Oct 25, 2021
utilities.go
Outdated
| @@ -57,6 +58,19 @@ func nodeName(node *html.Node) string { | |||
| } | |||
| } | |||
|
|
|||
| // Render renders the html of the first element from selector and writes it to the writer. | |||
| // It behaves similar to OuterHtml but takes io.Writer as input. | |||
There was a problem hiding this comment.
Suggested change
| // It behaves similar to OuterHtml but takes io.Writer as input. | |
| // It behaves the same as OuterHtml but writes to w instead of returning the string. |
There was a problem hiding this comment.
Makes sense! Done
utilities_test.go
Outdated
| @@ -81,48 +124,18 @@ func TestNodeNameMultiSel(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestOuterHtml(t *testing.T) { | |||
| func TestRender(t *testing.T) { | |||
There was a problem hiding this comment.
Ah yeah, given that this is exactly the same as TestOuterHtml and that OuterHtml calls Render anyway, it's fine to keep just TestOuterHtml.
mna
reviewed
Oct 25, 2021
utilities.go
Outdated
| if err := html.Render(w, n); err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Oh one more thing, this (lines 68-71) could be simplified to just return html.Render(w, n).
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377 issue