Use service for groups and permissions #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malberts
commented
Nov 8, 2021
| case 'group': | ||
| $observedValues = MediaWikiServices::getInstance() | ||
| ->getUserGroupManager() | ||
| ->getUserEffectiveGroups( $user ); |
There was a problem hiding this comment.
Still checking if getUserEffectiveGroups's implicit value for the second parameter ($queryFlags = self::READ_NORMAL) is fine. In the deprecated getEffectiveGroups method it is passing in User->queryFlagsUsed where the default is the same, but it is possible for that property's value to change (User->load*). However, I'm not 100% sure if the cases where it is changeable are relevant to Chameleon. It seems like when User is retrieved using Skin->getUser() it doesn't call those load methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #294