Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace isLoggedIn() #297

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Replace isLoggedIn() #297

merged 1 commit into from
Nov 6, 2021

Conversation

malberts
Copy link
Contributor

@malberts malberts commented Nov 6, 2021

Fixes: #295

@malberts malberts merged commit fbf0e91 into ProfessionalWiki:master Nov 6, 2021
@malberts malberts deleted the issue-295 branch November 6, 2021 20:28
@JeroenDeDauw
Copy link
Member

Does isRegistered do the same as isLoggedIn?!

@malberts
Copy link
Contributor Author

malberts commented Nov 7, 2021

Yes. isLoggedIn wraps isRegistered and the deprecation note suggests calling it directly.
https://www.mediawiki.org/wiki/Release_notes/1.35#Changes_since_MediaWiki_1.35.1

@bovender
Copy link

@malberts Would it please be possible to include this in a release, so I can update the skin via Composer? Currently my wiki shows a deprecation message on every page. Thanks so much!

@malberts
Copy link
Contributor Author

@bovender I think we can probably do the version 4 release soon, however I still need to make sure there are no major issues with MW 1.37 (although all unit tests pass already).

In the meantime, you can use this in your composer file to get the latest master code:

"mediawiki/chameleon-skin": "dev-master",

@bovender
Copy link

@malberts Thanks a million, didn't mean to rush you, the trick with "dev-master" is perfect for me right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User::isLoggedIn was deprecated in MediaWiki 1.36
3 participants