Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop builds if a build fails #119

Open
AlexU-A opened this issue Jul 25, 2017 · 5 comments
Open

Stop builds if a build fails #119

AlexU-A opened this issue Jul 25, 2017 · 5 comments
Assignees

Comments

@AlexU-A
Copy link

AlexU-A commented Jul 25, 2017

In order to prevent deployments or other build steps, it would be great to have the option to stop the build process upon receiving an error.

Current behavior:
In some cases when a build step fails, for example when a behat test fails, the build process continues to the next step.

Proposed behavior:
Allow a configuration option that denotes when an error in a build step should terminate the process.

@tortillaj
Copy link
Contributor

I think we should expand upon this idea a bit. Additionally, we add lifecycle hooks:

steps:
  .......
after_success:
  - command: .....
after_fail:
  - command: ...

@tizzo
Copy link
Contributor

tizzo commented Dec 6, 2017

Worth noting, this was implemented in the long-sitting build-class branch.

@tortillaj
Copy link
Contributor

@tizzo do you happen to remember the status of that branch? I know we still needed to track down a bug, but I don't remember exactly where it was left.

@tizzo
Copy link
Contributor

tizzo commented Dec 9, 2017 via email

@ElusiveMind ElusiveMind self-assigned this Nov 5, 2022
@ElusiveMind
Copy link
Contributor

Going to review these branches and see if I can get something testable on the lower environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants