Open generic pages and double tabs navigation

[JeremyBP]

Description of Change

Sometimes, we need to define some generic abstract classes. This could be the case for ContentPage like:

  MyAbstractContentPage<TOtherClass> : ContentPage where TOtherClass : IWhateverInterface

and then:

  MyContentPage : MyAbstractContentPage<MyOtherClass>

The problem is using AutoRegisterForNavigation attribute try to register MyAbstractContentPage and fails with container exception about registering open generic.
So I just added some filters on registration to ignore open generic classes.

Bugs Fixed

• AutoRegisterForNavigation attribute throw a container registration exception when using generic page class in project

API Changes

Changed:

• var viewTypes = assembly.ExportedTypes.Where(t => t.IsSubclassOf(typeof(Page)));
  =>
  var viewTypes = assembly.ExportedTypes.Where(t => t.IsSubclassOf(typeof(Page)) && !t.GetTypeInfo().IsGenericTypeDefinition && !t.GetTypeInfo().ContainsGenericParameters);

Behavioral Changes

Unchanged

PR Checklist

• Has tests
• Rebased on top of master at time of PR
• Changes adhere to coding standard

[dnfclas]

All CLA requirements met.

[JeremyBP]

Description of Change

In some scenarios, we need to implement a bottom tab bar (with a standard TabbedPage) and a top tab bar (i.e. with a Naxam TabbedPage) like Facebook does. In this case, we should look at the third parent to get a NavigationPage and beeing able to navigate as expected.

Bugs Fixed

• Navigating from a ContentPage contained in a top tabbed page itself contained in a bottom tabbed page (double tabs) shows in a modal way as it can't find a NavigationPage in contentPage.Parent?.Parent.

API Changes

Changed:

• if ((page.Parent is TabbedPage || page.Parent is CarouselPage) && page.Parent?.Parent is NavigationPage navigationParent)
  =>
  if ((page.Parent is TabbedPage || page.Parent is CarouselPage) && (page.Parent?.Parent is TabbedPage ? page.Parent?.Parent?.Parent : page.Parent?.Parent) is NavigationPage navigationParent)

Behavioral Changes

Unchanged

PR Checklist

• Has tests
• Rebased on top of master at time of PR
• Changes adhere to coding standard

[dansiegel]

@JeremyBP in the future you really need to open an issue so we can discuss this first. I agree that the issue of Open Generics is a use case that was not considered when Auto Registration was added so I have no problem adding that piece. But I need to think a bit on your solution for the TabbedPage issue... if you can do an interactive rebase to remove the second commit I am happy to merge the first piece.

[JeremyBP]

As I'm not "rebase aware" so far, I reverted last commit.
I know this is not the rebase you expected (and I should learn about it), so another option would be to simply reject this PR and update your code manualy with open generic ignore filters.
No authorship ambition on it ;)
About the double tab bar, I'll open an issue.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.