Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Shell for Dialogs #1868

Merged
merged 1 commit into from Aug 2, 2019
Merged

Support Shell for Dialogs #1868

merged 1 commit into from Aug 2, 2019

Conversation

dansiegel
Copy link
Member

Description of Change

Adds support for using the Dialog Service with Shell

Bugs Fixed

API Changes

none

Behavioral Changes

Adds internal check for when the MainPage is set to a Shell

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit ff8da00 into master Aug 2, 2019
@dansiegel dansiegel deleted the shelldialog branch August 2, 2019 16:31
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to launch the dialog box, when using Shell page
1 participant