Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to launch the dialog box, when using Shell page #1865

Closed
vk-makam opened this issue Aug 1, 2019 · 5 comments · Fixed by #1868
Closed

Unable to launch the dialog box, when using Shell page #1865

vk-makam opened this issue Aug 1, 2019 · 5 comments · Fixed by #1868

Comments

@vk-makam
Copy link

vk-makam commented Aug 1, 2019

Description

I am using AppShell along with Prism.DryIoC.Forms in one of our projects. We are unable to use the DialogService in AppShell pages (Tabs). We are using dialogService.ShowDialog("DemoDialog");

The same code is working fine in the normal ContentPage

Steps to Reproduce

  1. Launching the AppShell using MainPage = new AppShell();
  2. Created a DialogDemo.xaml and DialogDemo.xaml.cs (as mentioned in the Prism Issue 1825)
  3. Trying to launch the DialogDemo using DialogService in ViewModel

Expected Behavior

The DialogDemo should appear

Actual Behavior

Nothing happens

Basic Information

  • Version with issue: v7.2.0.1367
  • Last known good version:
  • Xamarin.Forms version: v4.1.0.618606
  • IDE: Visual Studio Mac 2019 (v8.2.1 build 19)

Screenshots

Reproduction Link

@brianlagunas
Copy link
Member

Prism does not support Shell. See #1809

@dansiegel
Copy link
Member

This is something that will need to be done in a separate effort from general "Shell Support". While #1809 is in fact labeled "Shell Support" what we're really talking about there is the Navigation Service. Also this should be fairly straight forward to handle where Shell Navigation is still pending fixes from the Xamarin.Forms team. @vk-makam please provide a simple reproduction app and we can reopen the issue.

@vk-makam
Copy link
Author

vk-makam commented Aug 2, 2019

Hi Dan,

Thanks for the reply. Please find the attached Xamarin.Forms project.

DialogDemo.zip

@vk-makam
Copy link
Author

vk-makam commented Aug 2, 2019

Hi Brain,

Thanks for the quick reply, I don't know about this. I will try to change them using TabbedPage/ MasterDetailPage.

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants