Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing NSIS commands #3504

Merged
merged 4 commits into from Jul 25, 2022
Merged

add missing NSIS commands #3504

merged 4 commits into from Jul 25, 2022

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Jul 25, 2022 •
edited

The following NSIS keywords have been added in recent versions and are missing in the highlighter

v3.08

v3.06

The Target key is (still) undocumented, but it has been endorsed by the NSIS developers so I think it should be added

See changelog for details

@github-actions
Copy link

github-actions bot commented Jul 25, 2022 •
edited

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +27 B (+1.3%).

file master pull size diff % diff
components/prism-nsis.min.js 2.03 KB 2.06 KB +27 B +1.3%

Generated by 🚫 dangerJS against 66e9476

@RunDevelopment
Copy link
Member

Thanks for the PR @idleberg!

Could you please add those keywords to the keyword test as well?

@RunDevelopment RunDevelopment merged commit b0c2a9b into PrismJS:master Jul 25, 2022
@RunDevelopment
Copy link
Member

Thank you @idleberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idleberg @RunDevelopment