Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gradle #3443

Merged
merged 9 commits into from Apr 29, 2022
Merged

Add support for Gradle #3443

merged 9 commits into from Apr 29, 2022

Conversation

zeabdelkhalek
Copy link
Contributor

This resolves #3353

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

JS File Size Changes (gzipped)

A total of 2 files have changed, with a combined diff of +721 B (+29.9%).

file master pull size diff % diff
components/prism-gradle.min.js 0 Bytes 716 B +716 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.41 KB 2.42 KB +5 B +0.2%

Generated by 🚫 dangerJS against 1692d91

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @zeabdelkhalek!

It seems like you based this language of Groovy. That's obviously a good choice, but please adjust the tests. It seems like most of them have just been copied over, so please adjust them. Btw, to update tests quickly, just run npm run test:languages -- --update.

Also, code style. Please copy the code style from languages. npm run lint:fix is probably a good start.

examples/prism-gradle.html Outdated Show resolved Hide resolved
@zeabdelkhalek
Copy link
Contributor Author

@RunDevelopment I have made the necessary changes, could you check again please?

components.json Outdated Show resolved Hide resolved
components/prism-gradle.js Outdated Show resolved Hide resolved
tests/languages/gradle/keyword_feature.test Show resolved Hide resolved
@zeabdelkhalek
Copy link
Contributor Author

@RunDevelopment fixed, can you check again?

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few minor things, but otherwise it's good to go.

Also, please run npm run build to update the minified files.

components.json Outdated Show resolved Hide resolved
components/prism-gradle.js Outdated Show resolved Hide resolved
components/prism-gradle.js Outdated Show resolved Hide resolved
examples/prism-gradle.html Outdated Show resolved Hide resolved
@zeabdelkhalek
Copy link
Contributor Author

@RunDevelopment can you check again?

@RunDevelopment RunDevelopment merged commit 3211982 into PrismJS:master Apr 29, 2022
@RunDevelopment
Copy link
Member

Thank you for contributing @zeabdelkhalek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle Syntax Support
3 participants