Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autohotkey: Use standard tokens #3385

Merged
merged 4 commits into from Mar 13, 2022

Conversation

RunDevelopment
Copy link
Member

As suggested here.

@github-actions
Copy link

github-actions bot commented Mar 12, 2022

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +29 B (+0.7%).

file master pull size diff % diff
components/prism-autohotkey.min.js 3.95 KB 3.98 KB +29 B +0.7%

Generated by 🚫 dangerJS against 836c4ed

Copy link
Contributor

@hoonweiting hoonweiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updated tokens are great! I'm just not very sure about builtin-function, since there is already a function for custom functions. Also, I think builtin is fine as it is, as we define builtin to be

Functions/Methods/Classes/Types that are available out of the box.

What do you think?

@RunDevelopment
Copy link
Member Author

Good point.

Copy link
Contributor

@hoonweiting hoonweiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@RunDevelopment RunDevelopment merged commit 61c460e into PrismJS:master Mar 13, 2022
@RunDevelopment RunDevelopment deleted the issue3170-autohotkey branch March 13, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants