Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Stata's Ado and Mata #3383

Merged
merged 3 commits into from Mar 21, 2022

Conversation

RunDevelopment
Copy link
Member

This fixes #3294.

This PR adds both Ado and Mata. This is because Ado embeds Mata, so I needed both (and because by the time I realized that the issue requested Ado instead of Mata, I had already implemented 80% of Mata...).

Frankly, implementing Ado wasn't fun. The documentation isn't great. I wasn't able to find any Ado overview, and I am sure as hell not gonna read the 2k pages of User guide + manual. I did read parts of the both, but the info I gathered wasn't great. As such, the syntax highlighting isn't great. It's passable and an ok first try, but not good. Hopefully, someone that actually knows the language can help improve it in the future.

Also, Ado's embedded Java, Mata, and Python aren't great. Ado allows for Ado variables within embedded sections of code. These variables aren't highlighted right now, because I would need #2002 to implement that.

Stata

image

Mata

image

@github-actions
Copy link

github-actions bot commented Mar 12, 2022

JS File Size Changes (gzipped)

A total of 4 files have changed, with a combined diff of +1.38 KB (+27.6%).

file master pull size diff % diff
components/prism-mata.min.js 0 Bytes 670 B +670 B +100.0%
components/prism-stata.min.js 0 Bytes 686 B +686 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.37 KB 2.39 KB +15 B +0.6%
plugins/show-language/prism-show-language.min.js 2.65 KB 2.66 KB +12 B +0.5%

Generated by 🚫 dangerJS against 2744699

@RunDevelopment RunDevelopment merged commit 63806d5 into PrismJS:master Mar 21, 2022
@RunDevelopment RunDevelopment deleted the issue3294 branch March 21, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New language request: Stata
1 participant