Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cooklang syntax highlighting - initial add #3337

Merged
merged 22 commits into from Feb 19, 2022
Merged

Conversation

ahue
Copy link
Contributor

@ahue ahue commented Feb 13, 2022

Adds syntax highlighting for cooklang.

@github-actions
Copy link

github-actions bot commented Feb 13, 2022

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +604 B (+100.0%).

file master pull size diff % diff
components/prism-cooklang.min.js 0 Bytes 604 B +604 B +100.0%

Generated by 🚫 dangerJS against 4277077

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ahue!

I have a few comments for you.

Also, regarding quoting properties: We generally only quote token names (e.g. comment, timer-group) and leave everything else unquoted (e.g. pattern, inside). This makes grammars more readable because it's easier to see what is and isn't a token name.

components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
ahue and others added 5 commits February 15, 2022 22:16
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
ahue and others added 5 commits February 16, 2022 22:41
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
@ahue
Copy link
Contributor Author

ahue commented Feb 16, 2022

@RunDevelopment - appreciate the feedback - it's really helpful!

components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
components/prism-cooklang.js Outdated Show resolved Hide resolved
ahue and others added 3 commits February 18, 2022 23:59
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
ahue and others added 2 commits February 19, 2022 00:03
Co-authored-by: Michael Schmidt <msrd0000@gmail.com>
@RunDevelopment RunDevelopment merged commit 4eb928c into PrismJS:master Feb 19, 2022
@RunDevelopment
Copy link
Member

Thank you for contributing @ahue!

@ahue
Copy link
Contributor Author

ahue commented Feb 19, 2022

Thanks for running this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants