Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added security policy #3070

Merged
merged 7 commits into from Jul 27, 2022
Merged

Added security policy #3070

merged 7 commits into from Jul 27, 2022

Conversation

RunDevelopment
Copy link
Member

After #2642 and #3069, I added a security policy. It's not much, but it's a decent start, I think.

This is only a draft. We still need to decide on how people should actually contact us.
Ideally, we would an email that forwards to all of us, so we can all respond.

@LeaVerou @mAAdhaTTah @Golmote


This resolves #2642.

@github-actions
Copy link

github-actions bot commented Sep 11, 2021

No JS Changes

Generated by 🚫 dangerJS against 7dc09fc

SECURITY.md Show resolved Hide resolved
@RunDevelopment
Copy link
Member Author

As we privately discussed, we will not acknowledge CVEs of low-severity ReDoS vulnerabilities and treat them as bugs instead. I added a section about the specifics to the security policy.

@RunDevelopment
Copy link
Member Author

@LeaVerou You own the domain prismjs.com, right? How difficult would it be to set up an email address security@prismjs.com that forwards all emails to us all?

@LeaVerou
Copy link
Member

Easy I think. I can look into it and get back to you!

@RunDevelopment
Copy link
Member Author

That would be great. Thank you!

@RunDevelopment
Copy link
Member Author

@LeaVerou ?

@RunDevelopment
Copy link
Member Author

Since the email seems to be holding this up, I changed the wording to essentially say "just contact a maintainer." That's pretty much what people are doing right now, and it seems to work. If we want to have a dedicated email for this in the future, we still can.

Of course, "contact a maintainer" has the slight problem that we don't have a list of maintainers yet, so I made PR for that (#3410).

Copy link
Collaborator

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nits about using newlines for each sentence -- IMHO it makes maintaining long-form markdown a bit easier since you can review each sentence as a "line of code", while paragraphs can still be separated w/ 2 lines :)

Content makes sense to me; I like the mix of disclosure strategies.

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@JaKXz JaKXz requested a review from LeaVerou March 22, 2022 17:40
@RunDevelopment
Copy link
Member Author

using newlines for each sentence

Good point. I can never remember whether GitHub's renderer for MD documents preserves newlines or not. (No, it doesn't. I looked it up.)

@RunDevelopment RunDevelopment marked this pull request as ready for review July 26, 2022 19:08
@RunDevelopment
Copy link
Member Author

Alright, with #3410 being merged, I updated SECURITY.md to link to MAINTAINERS.md for contact info. I think this PR is good as is right now. Please re-review.

Copy link
Collaborator

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RunDevelopment

@RunDevelopment RunDevelopment merged commit 05ee042 into master Jul 27, 2022
@RunDevelopment RunDevelopment deleted the Security-Policy branch July 27, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Prism.js not have a security policy?
4 participants