Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Highlighting: '/*' in string disrupts comment highlighting #3032

Closed
Josh-Cena opened this issue Aug 11, 2021 · 2 comments
Closed

JS Highlighting: '/*' in string disrupts comment highlighting #3032

Josh-Cena opened this issue Aug 11, 2021 · 2 comments

Comments

@Josh-Cena
Copy link

Josh-Cena commented Aug 11, 2021 •
edited

Information:

Description
When a string contains /* (which is common in configurations with glob matching), only the directly next line comment directive gets properly highlighted.

If a block comment is inserted somewhere, however, the subsequent line comments are parsed correctly again.

Example

image

(I am using the vscode-dark theme provided by prism-react-renderer)
@Josh-Cena Josh-Cena changed the title JS Highlighting: '/*' in string still parsed as comment JS Highlighting: '/*' in string disrupts comment highlighting Aug 11, 2021
@RunDevelopment
Copy link
Member

This has been fixed in 1.24.0. (live demo)

image

@Josh-Cena
Copy link
Author

Thanks. Turns out it's just that prism-react-renderer hasn't bumped its dependencies since two months ago...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RunDevelopment @Josh-Cena