Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KuMir #2760

Merged
merged 4 commits into from Feb 13, 2021
Merged

Add KuMir #2760

merged 4 commits into from Feb 13, 2021

Conversation

edukisto
Copy link
Contributor

Resolves #2759.

@github-actions
Copy link

github-actions bot commented Feb 12, 2021 •
edited

JS File Size Changes (gzipped)

A total of 3 files have changed, with a combined diff of +824 B (+18.9%).

file master pull size diff % diff
components/prism-kumir.min.js 0 Bytes 779 B +779 B +100.0%
plugins/autoloader/prism-autoloader.min.js 2.18 KB 2.19 KB +6 B +0.3%
plugins/show-language/prism-show-language.min.js 2.19 KB 2.23 KB +39 B +1.8%

Generated by 🚫 dangerJS against 0834cb9

@RunDevelopment
Copy link
Member

Oh oh. Sorry @edukisto. It's my fault CI fails. I'll try to fix it immediately.

@RunDevelopment RunDevelopment mentioned this pull request Feb 12, 2021
Merged
@RunDevelopment
Copy link
Member

@edukisto I fixed it now. Please rebase and then the CI should pass. I'm sorry for the inconvenience.

@edukisto edukisto closed this Feb 12, 2021
@edukisto edukisto deleted the topic-2759 branch February 12, 2021 21:07
@edukisto edukisto restored the topic-2759 branch February 12, 2021 21:08
@edukisto edukisto reopened this Feb 12, 2021
RunDevelopment
RunDevelopment requested changes Feb 12, 2021
View reviewed changes
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @edukisto!

I only have a few nits and then we can merge this.

I also thoroughly enjoyed reading through #2759. Thank you for the detailed explanation of a language that otherwise has little English documentation.

components/prism-kumir.js Outdated Show resolved Hide resolved
components/prism-kumir.js Outdated Show resolved Hide resolved
components/prism-kumir.js Outdated Show resolved Hide resolved
@RunDevelopment RunDevelopment merged commit 3419fb7 into PrismJS:master Feb 13, 2021
@RunDevelopment
Copy link
Member

Thank you very much for contributing @edukisto!

@edukisto edukisto deleted the topic-2759 branch February 13, 2021 14:37
This was referenced Jun 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support KuMir
2 participants
@edukisto @RunDevelopment