-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Autobuild job #2747
Comments
The repo code powers download page of the website, which is served from github pages & uses the minified files in the repo, so we need to commit the built files so it works. |
@mAAdhaTTah That is what I'm suggesting! :)
|
Oh, hmm, I suspect it would only work if the author gives us editing rights. Interesting idea tho so I'll keep this open. |
|
Only if they don't deselect the "Allow edits from maintainers" option. It's on by default tho. This actually has the nice side effect that users can actually opt-out of this feature, if implemented.
GitHub action workflows that commit code won't trigger the CI again. This is an explicit feature of GH actions. This behavior isn't a problem for the test suite (it doesn't use minified files) but it is a problem for the bundle size bot. The bot itself can't build the PR branch since that means executing untrusted code. (The bot runs in |
Currently in the final CI step Instead we could commit those files. Side-effect:
|
We could also ditch the older node versions. This has the disadvantage that version-specific bugs in node causing different build results might go undetected but it's a lot simpler. |
Motivation
When editing files here on GitHub one cannot run
npm run build
Description
Please consider adding a CI job:
npm run build
The text was updated successfully, but these errors were encountered: