feature: support for PHP 7.4 (typehint, return types) #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Oct 1, 2020
There was a problem hiding this comment.
Thank you for improving the PHP language definition @TomPavelec!
There are a few things that have to be improved but it looks ok overall.
RunDevelopment
requested changes
Oct 2, 2020
TomPavelec
force-pushed
the
feature/support_for_php_7_4
branch
12 times, most recently
from
f375187
to
a7f885c
Compare
RunDevelopment
requested changes
Oct 10, 2020
There was a problem hiding this comment.
@TomPavelec Again, sorry for the delay.
I reviewed it again and I think that it's almost ready to merge. We still have to decide what to do with your alias test implementation and I also left you some comments.
The conflicts resulting from #2574 also have to be resolved.
If you want to, then I'll make you a PR resolving some of my comments.
TomPavelec
force-pushed
the
feature/support_for_php_7_4
branch
from
a7f885c
to
69840ee
Compare
fix: `Foo::bar` Foo matched as class name fix: `new self` self matched as keyword instead of class name fix: `use function` is matched as package
feature: class name / namespace (package) can not begin with number feature: added binary and underscore number format feature: added operators `::`, `->`, `=>`, `<=>`, `...`, and some assignment operators fix: moved `.` from punctuation to operators (concatenation operator) feature: for `type` added subtypes `type-casting`, `type-hint`, `return-type` feature: added backtick string quoted string (shell exec) feature: for keywords `parent`, `self` and `static` added subtype `static-context` when a static prop/const/method accessed on them feature: for class name added subtype `class-name-fully-qualified` when class name is fully qualified feature: for class name added subtype `static-context` when a static prop/const/method accessed on it
fix: use single quotes for token names
fix: removed A-Z in case insensitive patterns removed: alias shell-comment fix: types handled as keywords
TomPavelec
force-pushed
the
feature/support_for_php_7_4
branch
from
3993ee1
to
39bbd69
Compare
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
Foo::barFoo matched as class namefix:
new selfself matched as keyword instead of class namefix:
use functionis matched as package