New Language: Keepalived configure file #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g detection, and added corresponding unit test.
… in `inside` object, Fix relational tests.
… `greedy` property to `true`
…ass` token (3) add `tag`, `selector-list`, `combinator` token
…`tag` behind the `n-th` token to avoid problem.
…est every character.
RunDevelopment
requested changes
Jun 9, 2020
There was a problem hiding this comment.
Thank you for this language definition @dev-itsheng!
I left you a few comments. Do you plan to include booleans as well?
|
I accepted all the suggestions and fixed them. In addition, I also did:
|
RunDevelopment
requested changes
Jun 16, 2020
There was a problem hiding this comment.
Thanks for the great work @dev-itsheng!
I looked over it again and left you some comments.
Make property token to two alphabetical sorting arrays, because the too long regex will make a error.
What do mean you by that? What error did you get?
Now our regex tooling can work its magic. This will make it easier to maintain the regex in the long run.
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +2.25 KB (+91.0%).
|
|
I quickly updated and finished the PR. |
RunDevelopment
approved these changes
Oct 3, 2021
|
Thank you for contributing @dev-itsheng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keepalived is a load balancing tools, it has a configure grammar which like Nginx but not same:
So I collect all of properties from its document and write some token like
ip,pathwhich hasaliaspattern of commonly token name.But the rule could not exactly right, because its document has also bug. In fact, I have made some PR to its GitHub repo with the wrong I found, There are still some errors that I did not find. Once found, I will update this language syntax and send PR to the that repo.
By the way, I think the nginx language could be rewrite like this. It is not C-Like grammar and could make lot of bugs in display. Maybe in next PR I will do it.