Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PureBasic #2369

Merged
merged 9 commits into from May 6, 2020
Merged

PureBasic #2369

merged 9 commits into from May 6, 2020

Conversation

HeX0R101
Copy link
Contributor

@HeX0R101 HeX0R101 commented May 6, 2020

New Language PureBasic added.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this PR @HeX0R101!

I left you two comments.
Also, there are a lot of small things I want to change before merging this. Is it ok if I just commit these changes directly into your branch?

tests/languages/purebasic/comment_feature.test Outdated Show resolved Hide resolved
components/prism-purebasic.js Outdated Show resolved Hide resolved
@HeX0R101
Copy link
Contributor Author

HeX0R101 commented May 6, 2020

Thank you for making this PR @HeX0R101!

I left you two comments.
Also, there are a lot of small things I want to change before merging this. Is it ok if I just commit these changes directly into your branch?

Sure!

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass. LGTM.

@RunDevelopment RunDevelopment merged commit d0c1c70 into PrismJS:master May 6, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @HeX0R101!

@RunDevelopment RunDevelopment mentioned this pull request May 6, 2020
quentinvernot pushed a commit to TankerHQ/prismjs that referenced this pull request Sep 11, 2020
A language based on Basic (BlitzBasic to be precise) with inline assembler also and direct API calls. Can compile on Windows, Linux, and macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants