Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is failing on develop for multiple reasons #27062

Closed
matks opened this issue Dec 22, 2021 · 2 comments · Fixed by #27055
Closed

CI is failing on develop for multiple reasons #27062

matks opened this issue Dec 22, 2021 · 2 comments · Fixed by #27055
Assignees
@PierreRambaud @jolelievre
Labels
Bug Type: Bug CI/CD Continuous Integration / Continuous Delivery CO Category: Core Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification develop Branch Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed Prerelease Bug found and fixed before the branch has been released Regression Type: regression
Projects
PrestaShop 8.0.0
Milestone
8.0.0

Comments

@matks
Copy link
Contributor

matks commented Dec 22, 2021 •
edited

We've had multiple CI failing issues today:

Behat CI failing

Following merge of PRs and the Behat tests were failing

Fixed by #27046 ✅

PHPUnit CI failing

Running phpunit using Composer binary is failing since composer/composer 2.2 composer/composer#10387

1) Tests\Integration\Adapter\Cart\CartPresenterTest::testProductAttributesAreProperlyConverted with data set #0 ('Taille : S- Couleur : Noir', array('S', 'Noir'))
PHPUnit\Framework\Exception: PHP Fatal error:  strict_types declaration must be the very first statement in the script in /home/runner/work/PrestaShop/PrestaShop/vendor/phpunit/phpunit/phpunit on line 2
Fatal error: strict_types declaration must be the very first statement in the script in /home/runner/work/PrestaShop/PrestaShop/vendor/phpunit/phpunit/phpunit on line 2

/home/runner/work/PrestaShop/PrestaShop/vendor/phpunit/phpunit/phpunit:60

Fixed by #27067 but long-term fix needed probably in a future Composer version ✅
@matks matks added Bug Type: Bug Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification CI/CD Continuous Integration / Continuous Delivery labels Dec 22, 2021
@matks
Copy link
Contributor Author

matks commented Dec 22, 2021

Similar output noticed on composer/composer#10387

@jolelievre jolelievre self-assigned this Dec 22, 2021
@jolelievre jolelievre linked a pull request Dec 22, 2021 that will close this issue
Split integration workflows into two, get rid of processIsolation #27055
Merged
@hibatallahAouadni hibatallahAouadni added CO Category: Core Ready Status: Issue is ready to be worked on develop Branch PR available Solution: issue is being addressed labels Dec 22, 2021
@hibatallahAouadni hibatallahAouadni added this to Not ready in PrestaShop 8.0.0 via automation Dec 22, 2021
@hibatallahAouadni hibatallahAouadni added the Regression Type: regression label Dec 22, 2021
@matks matks moved this from Not ready to In progress in PrestaShop 8.0.0 Dec 22, 2021
@prestashop-issue-bot prestashop-issue-bot bot added WIP Status: Work In Progress and removed Ready Status: Issue is ready to be worked on labels Dec 22, 2021
@matks
Copy link
Contributor Author

matks commented Dec 22, 2021

Work around provided by @PierreRambaud #27067

@matks matks closed this as completed Dec 22, 2021
PrestaShop 8.0.0 automation moved this from In progress to Done Dec 22, 2021
@prestashop-issue-bot prestashop-issue-bot bot added Fixed Resolution: issue closed because fixed and removed WIP Status: Work In Progress labels Dec 22, 2021
@matks matks added this to the 8.0.0 milestone Dec 22, 2021
This was referenced Dec 22, 2021
Merged
Merged
Merged
Merged
Merged
@eternoendless eternoendless added the Prerelease Bug found and fixed before the branch has been released label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PierreRambaud PierreRambaud

@jolelievre jolelievre

Labels
Bug Type: Bug CI/CD Continuous Integration / Continuous Delivery CO Category: Core Critical Severity: critical bug > https://build.prestashop.com/news/severity-classification develop Branch Fixed Resolution: issue closed because fixed PR available Solution: issue is being addressed Prerelease Bug found and fixed before the branch has been released Regression Type: regression
Projects
No open projects
PrestaShop 8.0.0
  
Done
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Split integration workflows into two, get rid of processIsolation jolelievre/PrestaShop
5 participants
@eternoendless @PierreRambaud @matks @jolelievre @hibatallahAouadni