Notice: Undefined offset 0 when generating PDF invoice for order with customized data

[rvalery]

Describe the bug
When you try to generate PDF invoices by date, a PHP notice is displayed if an order contains a product with a text customization field, but no file customization field. (I assume it will also fail if product contains a file customization field but no text customization field).

The PHP notice is "Notice: Undefined offset: 0" (see screenshot below)

To Reproduce
Steps to reproduce the behavior: Install last prestashop version and enable debug mode. Then :

1. In front-office : select the customizable mug example product, customize the text, add it to the cart

2. Proceed with order.

3. In Back-office : go to order page, and set the newly created order as delivered.

4. Go to invoice page, generate invoices by date.

5. Notice is displayed if in debug mode (if not in debug mode, invoice is generated properly, and notice is only logged into php error log).

Additional information
PrestaShop version: 1.7.6.1
PHP version: 5.6.30

The problem comes from the file pdf/invoice.product-tab.tpl, line 121 :
{if isset($customization.datas[$smarty.const._CUSTOMIZE_FILE_]) && count($customization.datas[$smarty.const._CUSTOMIZE_FILE_]) > 0}

When compiled by smarty, it is translated to :
<?php if ((($_smarty_tpl->tpl_vars['customization']->value['datas'][@constant('_CUSTOMIZE_FILE_')] !== null )) && count($_smarty_tpl->tpl_vars['customization']->value['datas'][@constant('_CUSTOMIZE_FILE_')]) > 0) {?>

Instead of isset, smarty uses a check against null value (!==null). Contrary to isset, this check raise the above mentionned notice. I have tested this on a prestashop 1.6 install (version 1.6.1.18), and the problem is not present. The compiled template is using a proper isset test :
<?php if (isset($_smarty_tpl->tpl_vars['customization']->value['datas'][@constant('_CUSTOMIZE_FILE_')])&&count($_smarty_tpl->tpl_vars['customization']->value['datas'][@constant('_CUSTOMIZE_FILE_')])>0) {?>

[khouloudbelguith]

Hi @rvalery,

Thanks for your report.
I manage to reproduce the issue with PS1.7.5.2 / PS1.7.6.0 & PS1.7.6.1.

Mode debug should be enabled
I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

[rvalery]

Thanks for your reply.
Unfortunately I have not yet found a way to correct this. I don't know if the problem is from Smarty itself (changing the isset into "!==null" check), or if it comes from a Prestashop configuration, or something in the way Prestashop uses smarty to compile templates. I will try to dig further in the code if I can find the time this week.

[wxiaoguang]

It is a smarty bug, please upgrade the smarty to the latest one:

https://github.com/smarty-php/smarty/blob/master/CHANGELOG.md

[3.1.35] - 2020-04-14

• fix errors that occured where isset was replaced with null check such as isset() check fails within section $VAR[loop].key syntax if "key" or "loop" does not exist smarty-php/smarty#453

[khouloudbelguith]

Hi @rvalery,

It is fixed in the 1.7.7.x branch.
I attached a screen record
https://drive.google.com/file/d/1EYXmI4-AMWXEzU02LQamVqJIn6AVuBMi/view?usp=sharing
Your ticket is a duplicate of #18837
So, I close it.
Thanks !

[khouloudbelguith]

Duplicate of #18837

[rvalery]

That is a good news, I will update to 1.7.7.x to test it.
Thanks !