Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated server on_startup/shutdown hooks to lifespan #8786

Closed
1 task done
zanieb opened this issue Mar 13, 2023 · 0 comments · Fixed by #8842
Closed
1 task done

Switch from deprecated server on_startup/shutdown hooks to lifespan #8786

zanieb opened this issue Mar 13, 2023 · 0 comments · Fixed by #8842
Labels
maintenance Chores and other work not directly related to the product

Comments

@zanieb
Copy link
Contributor

zanieb commented Mar 13, 2023

First check

  • I am a contributor to the Prefect codebase

Description

Starlette has deprecated the on_startup and on_shutdown hooks we are using for managing services. We should use the new interface.

See

Impact

This will make us compatible with future versions of Starlette.

Additional context

We should remove the ignore added in #8785

@zanieb zanieb added the maintenance Chores and other work not directly related to the product label Mar 13, 2023
mesejo added a commit to mesejo/prefect that referenced this issue Mar 18, 2023
mesejo added a commit to mesejo/prefect that referenced this issue Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Chores and other work not directly related to the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant