Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests for dynamic workspace files #9846

Open
jonatanschroeder opened this issue May 11, 2024 · 0 comments · May be fixed by #9855
Open

Add CI tests for dynamic workspace files #9846

jonatanschroeder opened this issue May 11, 2024 · 0 comments · May be fixed by #9855

Comments

@jonatanschroeder
Copy link
Member

A recent change in ESM exports caused issues in dynamic workspace files that were only detected by unrelated manual testing. A CI test would likely have caught these errors more quickly and avoided this problem. The test should include:

  • Static files in the workspace directory (for completeness);
  • Files in workspaceTemplates, with or without mustache extension;
  • Files linked from params;
  • Files with content in params, including text and binary, in utf-8, base64 and hex;
  • Blank files;
  • Files in subdirectories.
@jonatanschroeder jonatanschroeder linked a pull request May 15, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant