Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set workspace-jupyterlab-python to use 1001:1001, launch via gosu #9831

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set workspace-jupyterlab-python to use 1001:1001, launch via gosu #9831

wants to merge 3 commits into from

Conversation

echuber2
Copy link
Collaborator

@echuber2 echuber2 commented May 8, 2024

Fixes #9828

  • In the install script, we now change the default jovyan 1000:100 to 1001:1001. This also involved changing the default group "users" gid 100 to 1001 but not renaming the group.
  • Use gosu to step down to 1001:1001 when launched as 0:0 (in local testing, for example).
  • Tried using uv to accelerate pip install, since the build is pretty big/slow with so much happening all in the install script. (Maybe we should break out more Docker layers for caching, but the current synchronized apt upgrade with each change to pip packages may be desired.)

If anybody objects to the uv usage, it's no problem to back that out. The gosu stuff doesn't depend on it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited

All images

Image Platform Old Size New Size Change
prairielearn/executor:2d94759f8798afea968b9020f4f7c5f2a665adba null 1633.74 MB 1633.74 MB 0.00%
prairielearn/prairielearn:2d94759f8798afea968b9020f4f7c5f2a665adba linux/amd64 1633.74 MB 1633.74 MB -0.00%
prairielearn/workspace-jupyterlab-python:2d94759f8798afea968b9020f4f7c5f2a665adba linux/amd64 935.70 MB 886.44 MB -5.27%
prairielearn/workspace-jupyterlab-python:2d94759f8798afea968b9020f4f7c5f2a665adba linux/arm64 873.46 MB 823.71 MB -5.70%

@echuber2
ensure the gosu test failure will be more explicit
2d94759 
Adding the "or exit" ensures that the gosu test will be meaningful
even if somebody tries to remove the "set -e" option on the script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanschroeder jonatanschroeder Awaiting requested review from jonatanschroeder

@nwalters512 nwalters512 Awaiting requested review from nwalters512

@nicknytko nicknytko Awaiting requested review from nicknytko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jupyterlab workspace: implement gosu-helper functionality or equivalent
1 participant
@echuber2