Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank submitted answer is confusing for pl-file-editor #9806

Open
BenjaminCosman opened this issue May 2, 2024 · 5 comments
Open

Blank submitted answer is confusing for pl-file-editor #9806

BenjaminCosman opened this issue May 2, 2024 · 5 comments

Comments

@BenjaminCosman
Copy link
Contributor

image

As shown above, when you click Save on a pl-file-editor element, the "Submitted answer" at the bottom of the page is blank. I know from a handful of emails and CBTF incident reports that students sometimes believe this means their answer did not save correctly. Perhaps instead, either the box should show 1) the text of the saved answer, 2) the "Preview" of the saved answer, or 3) a message like "Your answer was saved."

@jonatanschroeder
Copy link
Member

For pl-file-editor the typical use is that you can add to the bottom of your question.html:

<pl-submission-panel>
  <pl-file-preview></pl-file-preview>
</pl-submission-panel>

@jonatanschroeder
Copy link
Member

If you want to see a formatted preview of your markdown submission instead, you can use:

<pl-submission-panel>
   <pl-xss-safe submitted-file-name="set1.md" language="markdown"></pl-xss-safe>
</pl-submission-panel>

@BenjaminCosman
Copy link
Contributor Author

I'll do that in the future; thanks! For folks who do not use this though, I wonder if one of the three options above might be a better default than a blank box? Most other elements show some representation of the submitted answer by default rather than a blank box.

@jonatanschroeder
Copy link
Member

@mwest1066 can probably talk to this further, but I believe changing this now may affect a lot of courses that rely on the current behavior.

@mwest1066
Copy link
Member

I agree that the current behavior is not good, and that we really should have some kind of default submission display. The backward compatibility problem that @jonatanschroeder mentions is definitely a problem, however. @nwalters512 tagging you in on this in case you've got any good ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants