Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review button for new variant when in previous variants #9780

Closed
jonatanschroeder opened this issue Apr 28, 2024 · 1 comment · Fixed by #9782
Closed

Review button for new variant when in previous variants #9780

jonatanschroeder opened this issue Apr 28, 2024 · 1 comment · Fixed by #9782

Comments

@jonatanschroeder
Copy link
Member

When I click on a previous variant, the button for "Try a new variant" shows. This button creates a new variant if no open variant exists, but if an open/incomplete variant exists, it switches to the open variant (i.e., a variant that has no submission, or one that has been saved but not graded, or one where the submission is ungradable, or one with multiple tries per variant). I believe this behaviour is expected and should remain, but the text of the button ("Try a new variant") is misleading. Ideally, if there is an open variant in the current instance question that is not the current one, we should change the text to something that says "Go to latest variant" or equivalent.

Also, that latest variant is never shown in the history. Should it? At least if it has a submission? In that case it could show "Open", or if it has a valid submission (e.g., >1 tries per submission) the percentage of the submissions so far plus "/Open"? Possibly with a different colour?

Originally posted by @jonatanschroeder in #6105 (review)

@mwest1066
Copy link
Member

I like all of these ideas, including the use of a different color for the latest variant badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants