New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read-only mode to file editor #9722

Open

eliotwrobson opened this issue Apr 15, 2024 · 1 comment

Labels

element

Collaborator

eliotwrobson commented Apr 15, 2024

See title, various screenshots of discussion are below. Should also hide the "restore original file" button mentioned by @/nwalters512 here.

eliotwrobson added the element label

Contributor

nwalters512 commented Apr 15, 2024

Bikeshed: readonly="true" vs. disabled="true" vs. editable="false"? I sorta like the first two since they borrow directly from HTML. Which one is appropriate depends on which semantics/behavior we want. From https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly#attribute_interactions:

The difference between disabled and readonly is that read-only controls can still function and are still focusable, whereas disabled controls can not receive focus and are not submitted with the form and generally do not function as controls until they are enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment