Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function without arguments not colorized #2558

Closed
gsscoder opened this issue Mar 15, 2020 · 4 comments
Closed

Function without arguments not colorized #2558

gsscoder opened this issue Mar 15, 2020 · 4 comments
Labels
Resolution-External Will close automatically.

Comments

@gsscoder
Copy link

Hi vscode-powershell team, thank you for great job!

It's more easy if I show you a screenshot:
ps-colorcoding-vscode

I expect ScriptName function to be colorized with a color different from the rest of the string.

Have a nice day.

Regards,
Giacomo S. S.

@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 15, 2020
@TylerLeonhardt
Copy link
Member

This should go in: https://github.com/PowerShell/EditorSyntax

Can you open this over there?

@TylerLeonhardt TylerLeonhardt added Resolution-External Will close automatically. and removed Needs: Triage Maintainer attention needed! labels Mar 15, 2020
@rkeithhill
Copy link
Collaborator

rkeithhill commented Mar 15, 2020

FWIW the regex's that drive the colorization are pretty complicated and brittle IMO. This would just work at the point we have semantic (AST) based colorization supported by the extension. I believe VSCode is looking into enabling this capability.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Mar 15, 2020
@TylerLeonhardt
Copy link
Member

Yeah when that is something that is possible, we can probably move to that. That said, I would expect a new issue to be opened for "Support semantic colorization" when that's possible for us to do so.

@gsscoder
Copy link
Author

@TylerLeonhardt, yes and sorry for delay. The issue was cloned here: PowerShell/EditorSyntax#198.

Bye

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Apr 22, 2020
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Apr 22, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-External Will close automatically.
Projects
None yet
Development

No branches or pull requests

3 participants